refactor(react-grid): replace render functions with components in TableView #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
changed the title
kvet
changed the title
kvet
changed the title
| @@ -21,25 +21,25 @@ describe('TableLayout', () => { | |||
| jest.resetAllMocks(); | |||
| }); | |||
|
|
|||
| it('should pass rowTemplate to TableLayoutCore', () => { | |||
| it('should pass rowComponent to TableLayoutCore', () => { | |||
| const rowTemplateMock = jest.fn(); | |||
| const rowTemplateArgs = { | |||
There was a problem hiding this comment.
Inconsistent names. It seems like they should contain *Component.
|
|
||
| A value with the following shape: | ||
|
|
||
| Field | Type | Description | ||
| ------|------|------------ | ||
| key | string | A table column's unique identifier. | ||
| type | string | Specifies the table column type. The specified value defines which cell template is used to render the column. | ||
| column? | [Column](#column) | Specifies the associated user column. | ||
| column? | [Column](#column-extension) | Specifies the associated user column. |
There was a problem hiding this comment.
It looks like you removed all '-' symbols from link anchors, but not here.
There was a problem hiding this comment.
It's a way markdown generate default header ids.
gsobolev
approved these changes
Nov 23, 2017
| const bodyTemplate = props => <tbody {...props} />; | ||
| const HeadTable = props => <Table use="head" {...props} />; | ||
| const TableHead = props => <thead {...props} />; | ||
| const TableBody = props => <thead {...props} />; |
There was a problem hiding this comment.
<thead {...props} /> -> <tbody {...props} /> ?
SergeyAlexeev
approved these changes
Nov 23, 2017
viterobk
approved these changes
Nov 27, 2017
dirk-pieterse
approved these changes
Nov 28, 2017
…ctive into tableview-templates-to-components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
The TableView's
tableLayoutTemplate,tableCellTemplate,tableRowTemplate,tableNoDataCellTemplate,tableNoDataRowTemplate,tableStubCellTemplate, andtableStubHeaderCellComponentproperties have been replaced withlayoutComponent,getCellComponent,rowComponent,noDataCellComponent,noDataRowComponent,stubCellComponentandstubHeaderCellComponent. This also means that they accept components instead of render functions. Find more details here: #496