refactor(react-grid): replace render functions with components in Grid #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsobolev
reviewed
Nov 16, 2017
| rootTemplate: PropTypes.func.isRequired, | ||
| headerPlaceholderTemplate: PropTypes.func, | ||
| footerPlaceholderTemplate: PropTypes.func, | ||
| rootComponent: PropTypes.func.isRequired, |
There was a problem hiding this comment.
Is PropTypes.func correct for this property?
There was a problem hiding this comment.
Yes. This is the way React components can be validated
kvet
changed the title
kvet
changed the title
…ctive into grid-tempates-to-components
| @@ -29,25 +29,23 @@ Field | Type | Description | |||
| name | string | Specifies the column name or the name of a row field whose value the column displays. If the column name does not match any field name, specify the `getCellValue` function. | |||
| getCellValue | (row: any, columnName: string) => any | Specifies the function used to get the column value for a given row. | |||
|
|
|||
| ### <a name="root-args"></a>RootArgs | |||
| ### RootProps | |||
|
|
|||
| Describes properties passed to the root template when it is being rendered. | |||
There was a problem hiding this comment.
'passed to the root template' -> 'passed to the root component' ? The same is in the HeaderPlaceholderProps, FooterPlaceholderProps
SergeyAlexeev
approved these changes
Nov 21, 2017
gsobolev
approved these changes
Nov 21, 2017
viterobk
approved these changes
Nov 22, 2017
dirk-pieterse
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
The Grid's
rootTemplate,headerPlaceholderTemplate, andfooterPlaceholderTemplateproperties have been replaced withrootComponent,headerPlaceholderComponent, andfooterPlaceholderComponent. This also means that they accept components instead of render functions. Find more details here: #496The
headerTemplate,bodyTemplate, andfooterTemplateproperties have been replaced with thechildrenproperty inrootTemplate.