refactor(react-grid): replace render functions with components in TableHeaderRow #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
changed the title
kvet
changed the title
viterobk
approved these changes
Nov 30, 2017
…ctive into tableheaderrow-components
SergeyAlexeev
approved these changes
Nov 30, 2017
gsobolev
approved these changes
Dec 4, 2017
dirk-pieterse
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
The TableHeaderRow's
headerCellTemplate, andheaderRowTemplateproperties have been replaced withgetCellComponent, androwComponent, which accept components instead of render functions. Find more details here: #496Properties passed to
getCellComponenthave the same names as arguments passed to theheaderCellTemplatefunction with the following exceptions: theonSort,onGroup,onWidthChangeandonDraftWidthChangeproperties are used instead of thechangeSortingDirection,groupByColumn,changeColumnWidthandchangeDraftColumnWidtharguments respectively.