Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reexports. #529

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add reexports. #529

wants to merge 8 commits into from

Conversation

Igggr
Copy link
Contributor

@Igggr Igggr commented Oct 12, 2021

Add reexports

packages/devextreme-vue/vue2-strategy/src/vector-map.ts

+export {
+  CenterChangedEvent,
+  ClickEvent,
+  DisposingEvent,
+  DrawnEvent,
+  ExportedEvent,
+  ExportingEvent,
+  FileSavingEvent,
+  IncidentOccurredEvent,
+  InitializedEvent,
+  OptionChangedEvent,
+  SelectionChangedEvent,
+  TooltipHiddenEvent,
+  TooltipShownEvent,
+  ZoomFactorChangedEvent,
+  MapLayer,
+  MapLayerElement,
+  LegendItem,
+  dxVectorMapAnnotationConfig,
+  dxVectorMapCommonAnnotationConfig,
+} from "devextreme/viz/vector_map";
import VectorMap, { Properties } from "devextreme/viz/vector_map";
import { createComponent } from "./core/index";
import { createConfigurationComponent } from "./core/index";

@Igggr Igggr added the enhancement New feature or request label Oct 12, 2021
@Igggr Igggr self-assigned this Oct 12, 2021
`export {\n <#= it.reexports.filter(n => n != 'default').join(',\\n ') #>,\n} from "<#= it.widgetsPackage #>/<#= it.widgetImport.path #>";\n` +
`<#?#>` +

`<#? !it.defaultExport && it.reexports?.includes('default') #>` +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test for this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided not to add test - but delete this line. Widget themself will always be default export.

@Igggr Igggr removed the request for review from IlyaKhD October 13, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants