Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more browserstack capabilities #54

Merged
merged 8 commits into from Feb 1, 2019
Merged

Add more browserstack capabilities #54

merged 8 commits into from Feb 1, 2019

Conversation

itszero
Copy link
Contributor

@itszero itszero commented Oct 11, 2018

Problem

I need access to more custom browserstack capabilities (console log, network log)

Solution

Refactor the code a little bit to have a more generic mapping which makes future updates easier. Added support for:

  • BROWSERSTACK_DEBUG
  • BROWSERSTACK_CONSOLE
  • BROWSERSTACK_NETWORK_LOGS
  • BROWSERSTACK_VIDEO
  • BROWSERSTACK_TIMEZONE

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit b0628e8 have failed. See details.

@itszero itszero mentioned this pull request Oct 15, 2018
Closed
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 292849c have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 292849c have passed. See details.

@itszero
Copy link
Contributor Author

itszero commented Jan 25, 2019

@AndreyBelym hey. any chance that we can get a review or merge here? Thanks!

AndreyBelym
AndreyBelym suggested changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@AndreyBelym AndreyBelym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great job done. Sorry for delays, I've been very busy in the main TestCafe repository. There are some points for improvements, but I really appreciate your contribution 👍

src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@itszero
Copy link
Contributor Author

itszero commented Jan 28, 2019

Thanks for the review. Updated the code to incorporate feedbacks!

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit f0dd0db have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 310d643 have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 465d91a have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c20d076 have failed. See details.

@AndreyBelym AndreyBelym force-pushed the zero/add-more-browserstack-caps branch from c20d076 to 28d6683 Compare February 1, 2019 08:16
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 28d6683 have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 28d6683 have passed. See details.

@AndreyBelym AndreyBelym merged commit 9d45bb6 into DevExpress:master Feb 1, 2019
@slatkovic
Copy link

Hey @AndreyBelym, I would love to get my hands on this capability - when do you plan on releasing this update?

@AndreyBelym
Copy link
Contributor

@slatkovic, it's published in the testcafe-browser-provider-browserstack@1.8.0 release.

@slatkovic
Copy link

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@itszero @testcafe-build-bot @slatkovic @AndreyBelym