Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentEditable elements with custom tag names are identified like not content editable #1366

Closed
AlexanderMoskovkin opened this issue Nov 10, 2017 · 2 comments
Closed

ContentEditable elements with custom tag names are identified like not content editable #1366

AlexanderMoskovkin opened this issue Nov 10, 2017 · 2 comments
Labels
!IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Milestone
Sprint #9

Comments

@AlexanderMoskovkin
Copy link
Contributor

Based on the discussion.

For example for element with the <rich-text-area> tag name.

The reason: take a look at this line.

It marks <rich-text-area> as always not content editable but actually it should mark only <area> elements.
@AlexanderMoskovkin AlexanderMoskovkin added this to the Sprint #9 milestone Nov 10, 2017
@miherlosev
Copy link
Contributor

I'm working on this

miherlosev pushed a commit to miherlosev/testcafe-hammerhead that referenced this issue Nov 12, 2017
fix 'ContentEditable elements with custom tag names are identified li…
ba07031 
…ke not content editable' (close DevExpress#1366)
miherlosev pushed a commit that referenced this issue Nov 14, 2017
@helen-dikareva @miherlosev
isContentEditable refactored (connected with #1366) (#1368)
c6cb1b3 
* isContentEditable refactored

* fix test
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@miherlosev @AndreyBelym
fix 'ContentEditable elements with custom tag names are identified li…
bf7355a 
…ke not content editable' (close DevExpress#1366) (DevExpress#1367)
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@helen-dikareva @AndreyBelym
isContentEditable refactored (connected with DevExpress#1366) (DevExp…
4601fd6 
…ress#1368)

* isContentEditable refactored

* fix test
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
!IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Projects
None yet
Milestone
Sprint #9
Development

No branches or pull requests
2 participants
@miherlosev @AlexanderMoskovkin