Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hammerhead.upload doesn't work properly #193

Closed
AlexanderMoskovkin opened this issue Oct 14, 2015 · 2 comments
Closed

Hammerhead.upload doesn't work properly #193

AlexanderMoskovkin opened this issue Oct 14, 2015 · 2 comments
Assignees
@churkin
Labels
AREA: client !IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot SYSTEM: upload TYPE: bug
Milestone
v1.0.0

Comments

@AlexanderMoskovkin
Copy link
Contributor

Hammerhead.upload published here:

this.upload = this.sandbox.upload.upload;

but it should be:

this.upload = this.sandbox.upload.upload.bind(this.sandbox.upload);

to have the correct context in the UploadSandbox.upload function
@AlexanderMoskovkin AlexanderMoskovkin added this to the v1.0.0 milestone Oct 14, 2015
@inikulin
Copy link
Contributor

I'd prefer to rename UploadSandox upload method to doUpload to avoid disambiguation.

@AlexanderMoskovkin AlexanderMoskovkin mentioned this issue Oct 14, 2015
Closed
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Oct 15, 2015
Hammerhead.upload doesn't work properly (close DevExpress#193)
abda41d
inikulin added a commit that referenced this issue Oct 15, 2015
@inikulin
Merge pull request #197 from churkin/i193
5eaa1da 
Hammerhead.upload doesn't work properly (close #193)
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@AndreyBelym
Hammerhead.upload doesn't work properly (close DevExpress#193)
e0de5a5
@lock
Copy link

lock bot commented Mar 29, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@churkin churkin

Labels
AREA: client !IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot SYSTEM: upload TYPE: bug
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@inikulin @churkin @AlexanderMoskovkin