The wrong processing of destructuring

[miherlosev]

If location declared inside function or passed as function parameter we should not process it.
It needs for fix #640 (comment)

Update! The origin issue was transfered to #2283

[iJigg]

This is being an issue for me right now.
Unfortunately I am not able to change the code below and this i blocking me from testing altogether.

renderThing({ history, location }) { ... }

get's transpiled into

renderThing({ history:history,location: __get$Loc(location) }) {  }

which throws Uncaught SyntaxError: Invalid destructuring assignment target

Any ETA on when this can be solved?

[Farfurix]

@iJigg

Hello,

Thank you for your example. We have plans to fix it. However, I cannot give you any precise time frames.

[silberjan]

@Farfurix this bug is making testcafe practically unusable for us right now. Is there any workaround until you fixed it?

[silberjan]

Okay i just found out myself.
Renaming the location param to anything else fixes the problem. I guess hammerhead always assumes location is window.location, which it is not for us.

[Farfurix]

@silberjan

Hello,

Yes, testcafe-hammerhead has special logic for the location object. Thank you for sharing your workaround. It can help other users work around the issue (when they are able to rename such objects in their projects).

We have plans to fix this issue. However, I cannot give you any estimates at the moment. Stay tuned for our updates here.

[LavrovArtem]

We need to transform the destructuring to fix this issue. This is a complex task. Here is how babel accomplishes it: https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-destructuring/src/index.js

[ajspott]

Another example occurs with Angular 9 + ngx-pipes within the ShufflePipe class

This:
[shuffled[i], shuffled[j]] = [shuffled[j], shuffled[i]];

Becomes this:
[ __get$(shuffled,i), __get$(shuffled,j)] = [ __get$(shuffled,j), __get$(shuffled,i)];