Get activeElement from Shadow DOM #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests for the commit 0c6f462 have passed. See details: |
churkin
approved these changes
Mar 16, 2017
miherlosev
requested changes
Mar 16, 2017
| return isDomElement(doc.activeElement) ? doc.activeElement : doc.body; | ||
| var el = isDomElement(doc.activeElement) ? doc.activeElement : doc.body; | ||
|
|
||
| while (el && el.shadowRoot) { |
There was a problem hiding this comment.
Is it possible to create nested shadowRoots?
Can active element be non isDomElement?
If it is true, then add tests for following cases.
|
❌ Tests for the commit 638bbc2 have failed. See details: |
miherlosev
approved these changes
Mar 17, 2017
|
❌ Tests for the commit 638bbc2 have failed. See details: |
|
Tests are ok (besides a blinking test), so I'll merge this |
AndreyBelym
added a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
* Get activeElement from Shadow DOM * Remove isDomElement check; add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @churkin @miherlosev