Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't raise the blur after focus on a not focusable element #2635

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

wentwrong
Copy link
Contributor

@wentwrong wentwrong commented May 18, 2021

Purpose

We shouldn't raise the blur event on an active element after the focus method was called on a not focusable element.

Approach

  • add check that if an element is not focusable, then the consecutive blur event is not needed when the focus method was called on this element
  • add more strict types

References

DevExpress/testcafe#6236

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@wentwrong wentwrong temporarily deployed to CI May 18, 2021 18:10 Inactive
@wentwrong wentwrong marked this pull request as ready for review May 19, 2021 08:19
@wentwrong
Copy link
Contributor Author

Functional tests are green in related TestCafe PR: DevExpress/testcafe#6236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants