Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turned on overriding send and setRequestHeader for XMLHttpRequest in NA mode #2890

Merged
merged 2 commits into from May 17, 2023

Conversation

Aleksey28
Copy link
Collaborator

@Aleksey28 Aleksey28 commented May 12, 2023

[closes DevExpress/testcafe#7664]
[closes DevExpress/testcafe#7686]

Purpose

Describe the problem you want to address or the feature you want to implement.

Approach

Describe how your changes address the issue or implement the desired functionality in as much detail as possible.

References

Provide a link to the existing issue(s), if any.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI May 12, 2023 11:57 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI May 12, 2023 12:26 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI May 15, 2023 13:43 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 changed the title fix: turned off overriding send for XMLHttpRequest fix: turned on overridings for XMLHttpRequest in NA mode May 15, 2023
@Aleksey28 Aleksey28 changed the title fix: turned on overridings for XMLHttpRequest in NA mode fix: turned on all overridings for XMLHttpRequest in NA mode May 15, 2023
@Aleksey28 Aleksey28 requested a review from miherlosev May 16, 2023 06:41
@Aleksey28 Aleksey28 temporarily deployed to CI May 16, 2023 07:10 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 changed the title fix: turned on all overridings for XMLHttpRequest in NA mode fix: turned on overriding setRequestHeader for XMLHttpRequest in NA mode May 16, 2023
@Aleksey28 Aleksey28 changed the title fix: turned on overriding setRequestHeader for XMLHttpRequest in NA mode fix: turned on overriding send and setRequestHeader for XMLHttpRequest in NA mode May 16, 2023
@miherlosev miherlosev merged commit c42cf99 into DevExpress:master May 17, 2023
8 checks passed
Aleksey28 added a commit to DevExpress/testcafe that referenced this pull request May 17, 2023
<!--
Thank you for your contribution.

Before making a PR, please read our contributing guidelines at

https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution

We recommend creating a *draft* PR, so that you can mark it as 'ready
for review' when you are done.
-->

## Purpose
Add tests for the [corresponding PR in
HH](DevExpress/testcafe-hammerhead#2890)

## Approach
_Describe how your changes address the issue or implement the desired
functionality in as much detail as possible._

## References
DevExpress/testcafe-hammerhead#2890

## Pre-Merge TODO
- [ ] Write tests for your proposed changes
- [ ] Make sure that existing tests do not fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants