Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added moving hidden input to the form bottom #2899

Merged
merged 5 commits into from
Jun 1, 2023

Conversation

Aleksey28
Copy link
Collaborator

@Aleksey28 Aleksey28 commented May 26, 2023

[closes DevExpress/testcafe#7489]

Purpose

Fix the issue with getting elements in form by index.

Approach

Move the custom hidden input element to the form bottom each time when a new element is added to that form.

References

Provide a link to the existing issue(s), if any.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI May 26, 2023 14:51 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI May 30, 2023 10:19 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 changed the title fix: added possible fix fix: added moving hidden input to the form bottom May 30, 2023
Copy link
Contributor

@miherlosev miherlosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

src/client/sandbox/upload/hidden-info.ts Outdated Show resolved Hide resolved
@Aleksey28 Aleksey28 temporarily deployed to CI May 30, 2023 12:27 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI May 30, 2023 12:28 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 merged commit b13a913 into DevExpress:master Jun 1, 2023
8 checks passed
@github-actions
Copy link

Release v31.4.4 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read properties of undefined (reading 'childNodes')
2 participants