Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging enhancements #2902

Merged
merged 6 commits into from
Jun 13, 2023
Merged

Logging enhancements #2902

merged 6 commits into from
Jun 13, 2023

Conversation

miherlosev
Copy link
Contributor

@miherlosev miherlosev commented Jun 6, 2023 •
edited

  1. Change debug namespace to simplify debug condition.

Before

set DEBUG=testcafe:*,hammerhead:*
testcafe chrome index.js 2> testcafe.log

After

set DEBUG=testcafe:*
testcafe chrome index.js 2> testcafe.log
  1. Simplify and beautify output
  2. Log register/unregister route actions

@miherlosev miherlosev temporarily deployed to CI June 6, 2023 07:28 — with GitHub Actions Inactive
@miherlosev miherlosev changed the title change debug namespace Logging enhancements Jun 7, 2023
@miherlosev miherlosev temporarily deployed to CI June 7, 2023 02:41 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI June 7, 2023 02:59 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI June 7, 2023 03:48 — with GitHub Actions Inactive
@miherlosev miherlosev marked this pull request as draft June 7, 2023 04:47
@miherlosev miherlosev marked this pull request as ready for review June 7, 2023 05:37
@miherlosev miherlosev temporarily deployed to CI June 7, 2023 05:38 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI June 7, 2023 08:04 — with GitHub Actions Inactive
@miherlosev miherlosev requested a review from Aleksey28 June 9, 2023 05:38
@miherlosev
Copy link
Contributor Author

miherlosev commented Jun 9, 2023 •
edited

You can review and merge it.
To green test its necessary change condition for the debug module - https://github.com/DevExpress/testcafe/blob/747ec24cd943b8f60d9f40650738bf045267bdce/test/functional/fixtures/browser-provider/browser-reconnect/test.js#L97.

@miherlosev miherlosev merged commit 7753bef into DevExpress:master Jun 13, 2023
6 of 8 checks passed
@miherlosev miherlosev deleted the change_debug_namespace branch June 13, 2023 09:12
@github-actions
Copy link

Release v31.4.5 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksey28 Aleksey28 Aleksey28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miherlosev @Aleksey28