Get rid of 'jobOwnerToken' and 'jobUid' in the code (close #39) #65
Conversation
|
Seems like it requires rebase |
|
Still requires rebase (since it's can't be automatically merged) |
|
@inikulin yes, I see, I try to figure it out. |
| }; | ||
|
|
||
| export default UrlUtil; | ||
| import NativeMethods from '../sandboxes/native-methods'; |
There was a problem hiding this comment.
Please, setup line endings in your editor to avoid this kind of diffs. We have the .editorconfig file which forces line endings, you just need to install editorconfig plugin for your WebStorm
There was a problem hiding this comment.
Oh, we don't have editorconfig for the hammerhead 😢
Please, add it as well: https://github.com/superroma/testcafe-phoenix/blob/master/.editorconfig
There was a problem hiding this comment.
And seems like latest WebStorm supports editorconfig out-of-the-box, so you don't need to install any plugins.
|
We need to get rid of huge diffs (see my comments above) and we're set. |
churkin
force-pushed
the
session-id
branch
2 times, most recently
from
2c1b6ba
to
e865d80
Compare
|
\r- |
churkin
force-pushed
the
session-id
branch
2 times, most recently
from
83ab940
to
94476bc
Compare
churkin
force-pushed
the
session-id
branch
3 times, most recently
from
8da929a
to
9a9aeff
Compare
|
FPR |
|
tests have passed |
|
lgtm |
|
@churkin Can you point me to the passed test run, please? |
|
lgtm |
Get rid of 'jobOwnerToken' and 'jobUid' in the code (close #39)
\cc @inikulin @LavrovArtem