This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Warnings #62
Merged
Warnings #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/reporter-object-factory.ts # src/types/testcafe.ts
Dmitry-Ostashev
approved these changes
Oct 11, 2021
VasilyStrelyaev
approved these changes
Nov 3, 2021
# Conflicts: # package-lock.json # package.json
aleks-pro
reviewed
Nov 15, 2021
src/types/report-warnings-args.ts
Outdated
| ) | ||
| ); | ||
|
|
||
| export type ReportWarningsArgs = t.TypeOf<typeof ReportWarningsSchema>; |
There was a problem hiding this comment.
Suggested change
| export type ReportWarningsArgs = t.TypeOf<typeof ReportWarningsSchema>; | |
| export type ReportWarningArgs = t.TypeOf<typeof ReportWarningsSchema>; |
src/report-commands-factory.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| import { AggregateCommandType, AggregateNames } from './types/internal/'; | |||
| import { TaskStartArgs, TestStartArgs, TestDoneArgs, TaskDoneArgs } from './types/'; | |||
| import { TaskStartArgs, TestStartArgs, TaskDoneArgs, TestDoneArgs } from './types/'; | |||
There was a problem hiding this comment.
Suggested change
| import { TaskStartArgs, TestStartArgs, TaskDoneArgs, TestDoneArgs } from './types/'; | |
| import { TaskStartArgs, TestStartArgs, TaskDoneArgs, TestDoneArgs, ReportWarningsArgs } from './types'; |
src/report-commands-factory.ts
Outdated
| import Transport from './transport'; | ||
| import { ReportWarningsArgs } from './types/report-warnings-args'; |
There was a problem hiding this comment.
Suggested change
| import { ReportWarningsArgs } from './types/report-warnings-args'; |
src/texts.ts
Outdated
| @@ -18,6 +18,9 @@ export const createFileUploadError = (uploadId: string, filePath: string): strin | |||
| export const createTestUploadError = (uploadId: string, testName: string): string => | |||
| `Failed to upload a test log. Upload ID: ${uploadId}, test name: ${testName}.`; | |||
|
|
|||
| export const createWarningUploadError = (uploadId: string, uploadEntityId: string): string => | |||
| `Failed to upload warnings. Upload ID: ${uploadId}, upload entity id: ${uploadEntityId}.`; | |||
There was a problem hiding this comment.
Did @titerman check this text?
There was a problem hiding this comment.
Suggested change
| `Failed to upload warnings. Upload ID: ${uploadId}, upload entity id: ${uploadEntityId}.`; | |
| `Failed to upload warning data. Upload ID: ${uploadId}, upload entity id: ${uploadEntityId}.`; |
src/types/index.ts
Outdated
| @@ -2,5 +2,6 @@ export * from './task-start-args'; | |||
| export * from './test-done-args'; | |||
| export * from './test-start-args'; | |||
| export * from './task-done-args'; | |||
| export * from './report-warnings-args'; | |||
There was a problem hiding this comment.
Suggested change
| export * from './report-warnings-args'; | |
| export * from './report-warning-args'; |
aleks-pro
approved these changes
Nov 15, 2021
titerman
approved these changes
Nov 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'reportWarnings' method support DevExpress/testcafe#6531
Sone notes: