initial (#4883)

src/client/driver/driver.js

@@ -291,7 +291,10 @@ export default class Driver extends serviceUtils.EventEmitter {
                 return browser.setActiveWindowId(this.browserActiveWindowId, hammerhead.createNativeXHR, this.windowId);
             })
             .then(() => {
-                this._startInternal({ finalizePendingCommand: true });
+                this._startInternal({
+                    finalizePendingCommand:             true,
+                    isFirstRequestAfterWindowSwitching: true
+                });
 
                 this.setAsMasterInProgress = false;
             })
@@ -1017,12 +1020,12 @@ export default class Driver extends serviceUtils.EventEmitter {
         };
     }
 
-    _startInternal (opts = { finalizePendingCommand: false }) {
+    _startInternal (opts) {
         this.role = DriverRole.master;
 
         browser.startHeartbeat(this.heartbeatUrl, hammerhead.createNativeXHR);
         this._setupAssertionRetryIndication();
-        this._startCommandsProcessing(opts.finalizePendingCommand);
+        this._startCommandsProcessing(opts);
     }
 
     _stopInternal () {
@@ -1049,7 +1052,7 @@ export default class Driver extends serviceUtils.EventEmitter {
 
     }
 
-    _startCommandsProcessing (finalizePendingCommand) {
+    _startCommandsProcessing (opts = { finalizePendingCommand: false, isFirstRequestAfterWindowSwitching: false }) {
         const pendingStatus = this.contextStorage.getItem(PENDING_STATUS);
 
         if (pendingStatus)
@@ -1069,9 +1072,12 @@ export default class Driver extends serviceUtils.EventEmitter {
         if (this._failIfClientCodeExecutionIsInterrupted())
             return;
 
-        finalizePendingCommand = finalizePendingCommand || this._hasPendingActionFlags(this.contextStorage);
+        const finalizePendingCommand = opts.finalizePendingCommand || this._hasPendingActionFlags(this.contextStorage);
 
-        const status = pendingStatus || new DriverStatus({ isCommandResult: finalizePendingCommand });
+        const status = pendingStatus || new DriverStatus({
+            isCommandResult:                    finalizePendingCommand,
+            isFirstRequestAfterWindowSwitching: opts.isFirstRequestAfterWindowSwitching
+        });
 
         this.contextStorage.setItem(this.COMMAND_EXECUTING_FLAG, false);
         this.contextStorage.setItem(this.EXECUTING_IN_IFRAME_FLAG, false);

src/client/driver/status.js

@@ -6,14 +6,15 @@ export default class DriverStatus extends Assignable {
     constructor (obj) {
         super(obj);
 
-        this.id                       = generateId();
-        this.isCommandResult          = false;
-        this.executionError           = null;
-        this.pageError                = null;
-        this.resent                   = false;
-        this.result                   = null;
-        this.consoleMessages          = null;
-        this.isPendingWindowSwitching = false;
+        this.id                                 = generateId();
+        this.isCommandResult                    = false;
+        this.executionError                     = null;
+        this.pageError                          = null;
+        this.resent                             = false;
+        this.result                             = null;
+        this.consoleMessages                    = null;
+        this.isPendingWindowSwitching           = false;
+        this.isFirstRequestAfterWindowSwitching = false;
 
         this._assignFrom(obj, true);
     }
@@ -25,7 +26,8 @@ export default class DriverStatus extends Assignable {
             { name: 'pageError' },
             { name: 'result' },
             { name: 'consoleMessages' },
-            { name: 'isPendingWindowSwitching' }
+            { name: 'isPendingWindowSwitching' },
+            { name: 'isFirstRequestAfterWindowSwitching' }
         ];
     }
 }

src/test-run/index.js

@@ -25,7 +25,6 @@ import { UNSTABLE_NETWORK_MODE_HEADER } from '../browser/connection/unstable-net
 import WarningLog from '../notifications/warning-log';
 import WARNING_MESSAGE from '../notifications/warning-message';
 import { StateSnapshot, SPECIAL_ERROR_PAGE } from 'testcafe-hammerhead';
-import { NavigateToCommand } from './commands/actions';
 import * as INJECTABLES from '../assets/injectables';
 import { findProblematicScripts } from '../custom-client-scripts/utils';
 import getCustomClientScriptUrl from '../custom-client-scripts/get-url';
@@ -53,6 +52,7 @@ const AssertionExecutor           = lazyRequire('../assertions/executor');
 const actionCommands              = lazyRequire('./commands/actions');
 const browserManipulationCommands = lazyRequire('./commands/browser-manipulation');
 const serviceCommands             = lazyRequire('./commands/service');
+const observationCommands         = lazyRequire('./commands/observation');
 
 const { executeJsExpression, executeAsyncJsExpression } = lazyRequire('./execute-js-expression');
 
@@ -491,13 +491,21 @@ export default class TestRun extends AsyncEventEmitter {
     }
 
     // Handle driver request
+    _shouldResolveCurrentDriverTask (driverStatus) {
+        const isFirstExecuteSelectorCommandAfterWindowSwitching =
+            driverStatus.isFirstRequestAfterWindowSwitching &&
+            this.currentDriverTask.command instanceof observationCommands.ExecuteSelectorCommand;
+
+        return !isFirstExecuteSelectorCommandAfterWindowSwitching;
+    }
+
     _fulfillCurrentDriverTask (driverStatus) {
         if (!this.currentDriverTask)
             return;
 
         if (driverStatus.executionError)
             this._rejectCurrentDriverTask(driverStatus.executionError);
-        else
+        else if (this._shouldResolveCurrentDriverTask(driverStatus))
             this._resolveCurrentDriverTask(driverStatus.result);
     }
 
@@ -788,7 +796,7 @@ export default class TestRun extends AsyncEventEmitter {
     }
 
     async navigateToUrl (url, forceReload, stateSnapshot) {
-        const navigateCommand = new NavigateToCommand({ url, forceReload, stateSnapshot });
+        const navigateCommand = new actionCommands.NavigateToCommand({ url, forceReload, stateSnapshot });
 
         await this.executeCommand(navigateCommand);
     }

test/functional/fixtures/run-options/allow-multiple-windows/pages/i4855/child.html

@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>i4855 - Child page</title>
+</head>
+<body>
+    <a href="http://localhost:3001/i4855">Open a self-closed page</a>
+</body>
+</html>

test/functional/fixtures/run-options/allow-multiple-windows/pages/i4855/index.html

@@ -0,0 +1,20 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>i4855 - Index page</title>
+</head>
+<body>
+    <!--
+        // NOTE: The problem is reproduced only for the following unstable scenario:
+        // - 'ExecuteSelectorCommand' is queried on the child page.
+        // - the child page is closed. At that moment, the result of the 'ExecuteSelectorCommand' was not sent to the server.
+        // - the parent page became a 'master' page and starts processing commands.
+        // - the initial command processing request on the new 'master' is interpreted as the 'ExecuteSelectorCommand'.
+        // This causes the crash down in the 'replicator' module.
+        // To create a stable reproducible example I am forced to guarantee that the result of the 'ExecuteSelectorCommand' isn't sent to the server.
+    -->
+    <a target="_blank" href="child.html">Open a new window</a><br/>
+    <span>Checked text</span>
+</body>
+</html>

test/functional/fixtures/run-options/allow-multiple-windows/test.js

@@ -72,4 +72,8 @@ describe('Allow multiple windows', () => {
                 return testCafe.close();
             });
     });
+
+    it("Should not finalize the 'ExecuteSelectorCommand' command on driver starting (GH-4855)", () => {
+        return runTests('testcafe-fixtures/i4855.js', null, { allowMultipleWindows: true });
+    });
 });

test/functional/fixtures/run-options/allow-multiple-windows/testcafe-fixtures/i4855.js

@@ -0,0 +1,11 @@
+import { Selector } from 'testcafe';
+
+fixture `Should not finalize the 'ExecuteSelectorCommand' command on driver starting (GH-4855)`
+    .page('http://localhost:3000/fixtures/run-options/allow-multiple-windows/pages/i4855/index.html');
+
+test('test', async t => {
+    await t
+        .click('a')
+        .click('a')
+        .expect(Selector('span').textContent).eql('Checked text');
+});

test/functional/site/server.js

@@ -69,6 +69,24 @@ Server.prototype._setupRoutes = function () {
         res.end(parsedUA.name);
     });
 
+    this.app.get('/i4855', (req, res) => {
+        res.send(`
+            <html>
+                <body>
+                    <script>
+                        var driver = window['%testCafeDriverInstance%'];
+
+                        driver._onExecuteSelectorCommand = function () {
+                            window.setTimeout(() =>{
+                                window.close();
+                            }, 1000);
+                        };
+                    </script>
+                </body>
+            </html>
+        `);
+    });
+
     this.app.get('*', function (req, res) {
         const reqPath      = req.params[0] || '';
         const resourcePath = path.join(server.basePath, reqPath);