Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not finalize the "ExecuteSelectorCommand" command on driver starting #4855

Closed
miherlosev opened this issue Mar 11, 2020 · 2 comments · Fixed by amalsgit/testcafe-curr-conveter#16
Assignees
Labels
FREQUENCY: level 2 STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: window management TYPE: bug The described behavior is considered as wrong (bug).
Milestone

Comments

@miherlosev
Copy link
Collaborator

miherlosev commented Mar 11, 2020

Example (pseudo code):

  await t
    .click('a[target=blank]')
   .click('link on child page') // a few page redirects here
    .expect(('selector-on-child-page').textContent).ok()

The test execution report will contain the following error:

TypeError: Cannot read property '0' of null
    at DecodingTransformer.transform (C:\repos\testcafe\node_modules\replicator\index.js:279:27)
    at module.exports.Replicator.decode (C:\repos\testcafe\node_modules\replicator\index.js:565:24)
    at SelectorBuilder._processResult (C:\repos\testcafe\src\client-functions\client-function-builder.js:146:32)
    at SelectorBuilder._processResult (C:\repos\testcafe\src\client-functions\selectors\selector-builder.js:197:32)
    at re_executable_promise_1.default.fromFn (C:\repos\testcafe\src\client-functions\client-function-builder.js:141:25)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Found in 'Login via Google' case.

@miherlosev miherlosev added SYSTEM: window management TYPE: bug The described behavior is considered as wrong (bug). FREQUENCY: level 2 labels Mar 11, 2020
@miherlosev miherlosev changed the title Don't finalize the pending command in case of the 'ExecuteSelectorCommand' command Should not finalize the "ExecuteSelectorCommand" command on driver starting Mar 11, 2020
@AndreyBelym AndreyBelym added this to the Sprint #53 milestone Mar 13, 2020
@miherlosev miherlosev self-assigned this Mar 13, 2020
@miherlosev
Copy link
Collaborator Author

Fixed in 36337d3

@lock
Copy link

lock bot commented Apr 15, 2020

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Apr 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FREQUENCY: level 2 STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: window management TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants