Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add info about the file:// protocol to a recipe #1255

Merged
merged 4 commits into from Mar 24, 2017
Merged

[docs] Add info about the file:// protocol to a recipe #1255

merged 4 commits into from Mar 24, 2017

Conversation

VasilyStrelyaev
Copy link
Collaborator

\cc @DevExpress/testcafe-docs

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 8bc4a82 have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 32fc258 have passed. See details.

@inikulin
Copy link
Contributor

We need docs at first, so it can be referenced here (I guess it should be described in .page section)

@VasilyStrelyaev
Copy link
Collaborator Author

Well, this PR actually adds one sentence and an example to .page section

@VasilyStrelyaev VasilyStrelyaev mentioned this pull request Feb 21, 2017
Merged
@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 492047d have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 8ccb740 have passed. See details.

kirovboris
kirovboris requested changes Feb 27, 2017
View reviewed changes
Copy link
Collaborator

@kirovboris kirovboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/r-

docs/articles/documentation/test-api/test-code-structure.md Outdated
To test webpages in local directories, you can use the `file://` protocol.

```js
fixture `MyFixture`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, we can use relative path as well.

    fixture `MyFixture`
        .page `../my-website/index.html`;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LavrovArtem is it true?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VasilyStrelyaev I think this question is about testcafe but not testcafe-hammerhead. I don't know how it works in testcafe.
@AndreyBelym ping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relative to what it will be then in your opinion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be relative to current test file, e.g. if i have .html pages for every test and i store them in repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you speaking about file: protocol, your example shows URL. If so, yes, it would be nice to have relative path support (I suppose we don't have one at the moment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use relative paths for pages only in legacy API if you have specified baseUrl in test_config.json. Currently you can only skip protocol from URL, in this case it's assumed to be http://. So relative file-protocol URLs certainly don't work now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1286

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit faa26e7 have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit f9872ab have passed. See details.

@AlexanderMoskovkin
Copy link
Contributor

ping @inikulin @LavrovArtem @AndreyBelym

AndreyBelym
AndreyBelym approved these changes Mar 10, 2017
View reviewed changes
Copy link
Contributor

@AndreyBelym AndreyBelym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 3ec9c4f have passed. See details.

@VasilyStrelyaev
Copy link
Collaborator Author

If we are not going to do #1286 in this sprint, let's review this as is

inikulin
inikulin suggested changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@inikulin inikulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be released without #1286. Feature is not ready.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 4fff771 have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit acf75c0 have failed. See details.

@VasilyStrelyaev
Copy link
Collaborator Author

@testcafe-build-bot \retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit acf75c0 have passed. See details.

inikulin
inikulin approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@inikulin inikulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inikulin inikulin merged commit 33c42b0 into DevExpress:master Mar 24, 2017
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this pull request Dec 18, 2019
@VasilyStrelyaev @kirovboris
[docs] Add info about the file:// protocol to a recipe (DevExpress#1255)
b7509d4 
* Add info about the file protocol

* Add docs for file protocol

* Add info about relative URLs

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inikulin inikulin inikulin approved these changes

@kirovboris kirovboris kirovboris approved these changes

@AndreyBelym AndreyBelym AndreyBelym approved these changes

@churkin churkin churkin approved these changes

@LavrovArtem LavrovArtem LavrovArtem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@VasilyStrelyaev @testcafe-build-bot @inikulin @AlexanderMoskovkin @kirovboris @AndreyBelym @churkin @LavrovArtem