Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle target elements that are inside Shadow DOM (closes #1312) #1319

Merged
merged 1 commit into from Mar 20, 2017
Merged

Handle target elements that are inside Shadow DOM (closes #1312) #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -91,7 +91,7 @@
"stack-chain": "^1.3.6",
"strip-bom": "^2.0.0",
"testcafe-browser-tools": "1.2.1",
"testcafe-hammerhead": "10.6.0",
"testcafe-hammerhead": "10.6.1",
"testcafe-legacy-api": "2.0.2",
"testcafe-reporter-json": "^2.1.0",
"testcafe-reporter-list": "^2.1.0",
Expand Down
9 changes: 9 additions & 0 deletions src/client/core/utils/position.js
View file
Open in desktop
Expand Up @@ -229,6 +229,15 @@ export function getElementFromPoint (x, y) {
if (el === null)
el = func.call(document, x - 1, y - 1);

while (el && el.shadowRoot) {
var shadowEl = el.shadowRoot.elementFromPoint(x, y);

if (!shadowEl)
break;

el = shadowEl;
}

return el;
}

Expand Down
22 changes: 22 additions & 0 deletions test/functional/fixtures/regression/gh-1312/pages/index.html
View file
Open in desktop
@@ -0,0 +1,22 @@
<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body>
<div id="host">Shadow DOM</div>
<script>
var host = document.querySelector('#host');
var root = host.createShadowRoot();
var header = document.createElement('h1');
var input = document.createElement('input');

header.textContent = 'Test Me!';

header.addEventListener('click', () => header.textContent = 'Test passed');

root.appendChild(header);
root.appendChild(input);
</script>
</body>
</html>
15 changes: 15 additions & 0 deletions test/functional/fixtures/regression/gh-1312/test.js
View file
Open in desktop
@@ -0,0 +1,15 @@
describe('[Regression](GH-1312)', function () {
it('Should preform a click action on the element inside shadow DOM', function () {
return runTests('testcafe-fixtures/index-test.js', 'click', {
// NOTE: Currently supported in Chrome only: http://caniuse.com/#feat=shadowdom
only: 'chrome'
});
});

it('Should preform a typeText action on the element inside shadow DOM', function () {
return runTests('testcafe-fixtures/index-test.js', 'typeText', {
// NOTE: Currently supported in Chrome only: http://caniuse.com/#feat=shadowdom
only: 'chrome'
});
});
});
19 changes: 19 additions & 0 deletions test/functional/fixtures/regression/gh-1312/testcafe-fixtures/index-test.js
View file
Open in desktop
@@ -0,0 +1,19 @@
import { Selector } from 'testcafe';

fixture `gh-1312`
.page `http://localhost:3000/fixtures/regression/gh-1312/pages/index.html`;

const shadowHeader = Selector(() => document.querySelector('#host').shadowRoot.querySelector('h1'));
const shadowInput = Selector(() => document.querySelector('#host').shadowRoot.querySelector('input'));

test('click', async t => {
await t
.click(shadowHeader)
.expect(shadowHeader.innerText).eql('Test passed');
});

test('typeText', async t => {
await t
.typeText(shadowInput, 'Test passed')
.expect(shadowInput.value).eql('Test passed');
});