New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scrolling when page has negative margins (#2601) #3923

Merged

AndreyBelym merged 3 commits into DevExpress:master from AlexKamaev:gh-2601

Jul 2, 2019

Contributor

AlexKamaev commented Jun 24, 2019 •

edited

The problem appears if:

Body has overflow: auto (here it implicitly has overflow-y auto)
Body has defined height
Body has a child with negative margin
This markup leads to incorrect calculations of html scrollHeight

Contributor Author

AlexKamaev commented Jun 24, 2019

@testcafe-build-bot retest

Collaborator

testcafe-build-bot commented Jun 24, 2019

❌ Tests for the commit 8be6448 have failed. See details:

Collaborator

testcafe-build-bot commented Jun 24, 2019

❌ Tests for the commit 8be6448 have failed. See details:

AlexKamaev closed this

AlexKamaev reopened this

Collaborator

testcafe-build-bot commented Jun 24, 2019

❌ Tests for the commit a2158fd have failed. See details:

Collaborator

testcafe-build-bot commented Jun 25, 2019

❌ Tests for the commit a2158fd have failed. See details:

Collaborator

testcafe-build-bot commented Jun 25, 2019

✅ Tests for the commit a2158fd have passed. See details:

AlexKamaev requested review from helen-dikareva and AndreyBelym

June 25, 2019 13:31

AlexKamaev changed the title ~~[WIP]fix scrolling when page has negative margins (#2601)~~ fix scrolling when page has negative margins (#2601)

Contributor Author

AlexKamaev commented Jun 27, 2019

ping

Collaborator

helen-dikareva commented Jun 27, 2019

I'm in progress (have been reading a long feed in the original issue)

helen-dikareva reviewed

View reviewed changes

test/functional/fixtures/regression/gh-2601/test.js Outdated

+                      return runTests('testcafe-fixtures/index.js');
+                  });
+              });

Collaborator

helen-dikareva Jun 27, 2019

Two extra lines

test/functional/fixtures/regression/gh-2601/test.js Show resolved Hide resolved

AndreyBelym approved these changes

View reviewed changes

helen-dikareva approved these changes

View reviewed changes

Collaborator

testcafe-build-bot commented Jun 27, 2019

❌ Tests for the commit 9c0c20f have failed. See details:

Contributor Author

AlexKamaev commented Jun 27, 2019

@testcafe-build-bot retest

Collaborator

testcafe-build-bot commented Jun 27, 2019

❌ Tests for the commit 9c0c20f have failed. See details:

Contributor Author

AlexKamaev commented Jun 28, 2019

I hope that tests will not be so flaky after this pull #3939
I'll rebase and restart these tests after the 3939 is merged

Collaborator

testcafe-build-bot commented Jun 28, 2019

❌ Tests for the commit 9c0c20f have failed. See details:

Collaborator

testcafe-build-bot commented Jun 28, 2019

❌ Tests for the commit 9c0c20f have failed. See details:

1 similar comment

Collaborator

testcafe-build-bot commented Jun 28, 2019

❌ Tests for the commit 9c0c20f have failed. See details:

Collaborator

testcafe-build-bot commented Jun 28, 2019

❌ Tests for the commit 9c0c20f have failed. See details:

AndreyBelym force-pushed the gh-2601 branch from 9c0c20f to 649bf4b Compare

July 1, 2019 17:40

Collaborator

testcafe-build-bot commented Jul 1, 2019

❌ Tests for the commit 649bf4b have failed. See details:

AlexKamaev added 3 commits

July 2, 2019 10:20


          fix scrolling when page has negative margins

4bd5957

fix

ebf8444


          improve tests

abaf73a

AlexKamaev force-pushed the gh-2601 branch from 649bf4b to abaf73a Compare

July 2, 2019 07:21

Collaborator

testcafe-build-bot commented Jul 2, 2019

❌ Tests for the commit abaf73a have failed. See details:

Collaborator

testcafe-build-bot commented Jul 2, 2019

✅ Tests for the commit abaf73a have passed. See details:

AndreyBelym merged commit 7a97fe0 into DevExpress:master

kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this pull request


          fix scrolling when page has negative margins (DevExpress#2601) (DevEx…

f2a8a69

…press#3923)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment