Fix test file scanning for Windows (closes #3918) #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit ee99956 have failed. See details: |
|
❌ Tests for the commit ee99956 have failed. See details: |
2 similar comments
|
❌ Tests for the commit ee99956 have failed. See details: |
|
❌ Tests for the commit ee99956 have failed. See details: |
kirovboris
approved these changes
Jun 24, 2019
miherlosev
requested changes
Jun 25, 2019
|
❌ Tests for the commit e1ccd2d have failed. See details: |
|
❌ Tests for the commit f19fa76 have failed. See details: |
|
✅ Tests for the commit f19fa76 have passed. See details: |
miherlosev
approved these changes
Jun 26, 2019
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
…ss#3927) * Fix test file scanning for Windows * Refactor after review * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3918. Luckily I found a function that allowed me to avoid rewriting half of the
globbycode. Can't write a test for the fixed even withproxyquire, because the issue was caused by the internals ofnode-glob.