Enable downloading files to the default directory for Chrome Headless (closes #3127) #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miherlosev
requested changes
Jul 18, 2019
|
|
||
| return tab; | ||
| return tabs.filter(t => t.type === 'page' && t.url.indexOf(browserId) > -1)[0]; |
There was a problem hiding this comment.
Instead of string.indexOf(subString) > -1 it's possible to use string.includes(subString).
It is a little readable and shorter.
| @@ -72,7 +120,7 @@ export async function createClient (runtimeInfo) { | |||
| runtimeInfo.client = client; | |||
|
|
|||
| await client.Page.enable(); | |||
| await client.Network.enable(); | |||
| await client.Network.enable({}); | |||
There was a problem hiding this comment.
Is {} argument necessary?
There was a problem hiding this comment.
It's required by type definitions:
https://github.com/ChromeDevTools/devtools-protocol/blob/master/types/protocol-proxy-api.d.ts#L1944
As you can see params is not optional.
miherlosev
approved these changes
Jul 18, 2019
|
❌ Tests for the commit 0eb95c5 have failed. See details: |
|
✅ Tests for the commit 0eb95c5 have passed. See details: |
AlexKamaev
reviewed
Jul 22, 2019
test/functional/fixtures/regression/gh-3127/testcafe-fixtures/index-test.js
Show resolved
Hide resolved
AlexKamaev
approved these changes
Jul 22, 2019
|
❌ Tests for the commit e288d6f have failed. See details: |
|
✅ Tests for the commit e288d6f have passed. See details: |
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3127.