fix module cache clearing in live mode for Node 12 (closes #4052) #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit a6d615d have failed. See details: |
|
❌ Tests for the commit a6d615d have failed. See details: |
|
❌ Tests for the commit 982d567 have failed. See details: |
LavrovArtem
approved these changes
Aug 5, 2019
|
❌ Tests for the commit 982d567 have failed. See details: |
|
✅ Tests for the commit 982d567 have passed. See details: |
AndreyBelym
reviewed
Aug 5, 2019
| @@ -57,7 +57,7 @@ export default class ModulesGraph { | |||
| if (!cache[node]) | |||
| return; | |||
|
|
|||
| cache[node] = null; | |||
| cache[node] = void 0; | |||
There was a problem hiding this comment.
I think if we can just delete cache[node], can't we?
|
❌ Tests for the commit 87f6ea2 have failed. See details: |
AndreyBelym
suggested changes
Aug 5, 2019
|
✅ Tests for the commit 87f6ea2 have passed. See details: |
AndreyBelym
approved these changes
Aug 8, 2019
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cause is here https://github.com/nodejs/node/blob/master/lib/internal/modules/cjs/loader.js#L617
and the pull is here nodejs/node@0f190a5