Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick live fix #4258

Merged
merged 2 commits into from Sep 12, 2019
Merged

quick live fix #4258

merged 2 commits into from Sep 12, 2019

Conversation

AlexKamaev
Copy link
Contributor

No description provided.

AndreyBelym
AndreyBelym suggested changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@AndreyBelym AndreyBelym left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we missed this since TypeScript can't properly check interface compliance for JS classes (like src/live/controller.js. So let's rewrite src/live/controller.js in TypeScript.

Also, we should avoid using _dashedMethodNames in the LiveModeController interface and in any future interfaces. We use this naming convention for private API only. Interfaces are designed to create public API contracts. E.g. LiveModeController's methods are called from a class that doesn't implement it, it is a public API.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 19bf008 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit ecf60f3 have failed. See details:

@AlexKamaev
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit ecf60f3 have failed. See details:

@AlexKamaev
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit ecf60f3 have passed. See details:

@AndreyBelym AndreyBelym self-requested a review September 12, 2019 10:49
@AndreyBelym AndreyBelym merged commit 24ff573 into DevExpress:master Sep 12, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this pull request Dec 18, 2019
@AlexKamaev @kirovboris
Fix crash when using keyboard shortcuts in Live mode (DevExpress#4258)
5232f0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miherlosev miherlosev miherlosev approved these changes

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexKamaev @testcafe-build-bot @miherlosev @AndreyBelym