Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add the Pull Request Template #4759

Merged
merged 2 commits into from Feb 17, 2020
Merged

[docs] Add the Pull Request Template #4759

merged 2 commits into from Feb 17, 2020

Conversation

AlexSkorkin
Copy link
Collaborator

No description provided.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit e3e604b have failed. See details.

kirovboris
kirovboris requested changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@kirovboris kirovboris left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[not relevant]

@AlexSkorkin
Copy link
Collaborator Author

We should add a link to
https://github.com/DevExpress/testcafe/blob/cf74ca1c62f373b5166122b686eb8d21bf495ba3/CONTRIBUTING.md

There's a link at the top. Is it wrong?

image

AndreyBelym
AndreyBelym approved these changes Feb 13, 2020
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@AndreyBelym
Copy link
Contributor

AndreyBelym commented Feb 13, 2020 •
edited

Well, actually it's a good idea to always open your PR as a draft. But it's a very minor point, this template is quite good as it is.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c281705 have failed. See details.

1 similar comment
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c281705 have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 6dc525c have passed. See details.

@AndreyBelym AndreyBelym merged commit 1b7d951 into master Feb 17, 2020
@AlexSkorkin AlexSkorkin deleted the AlexSkorkin-PR-template branch February 17, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirovboris kirovboris kirovboris approved these changes

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
TYPE: repo maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexSkorkin @testcafe-build-bot @AndreyBelym @kirovboris