Passing configuration options to reporter (closes #5088) #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
|
❌ Tests for the commit cfb5040 have failed. See details: |
need-response-app
bot
removed
the
STATE: Need response
AndreyBelym
reviewed
May 20, 2020
|
❌ Tests for the commit 83dc7a5 have failed. See details: |
|
❌ Tests for the commit 83dc7a5 have failed. See details: |
|
✅ Tests for the commit 83dc7a5 have passed. See details: |
AndreyBelym
approved these changes
May 22, 2020
AlexKamaev
reviewed
May 26, 2020
src/reporter/index.js
Outdated
| @@ -172,7 +172,7 @@ export default class Reporter { | |||
| const userAgents = task.browserConnectionGroups.map(group => group[0].userAgent); | |||
| const first = this.reportQueue[0]; | |||
|
|
|||
| await this.plugin.reportTaskStart(startTime, userAgents, this.testCount, task.testStructure); | |||
| await this.plugin.reportTaskStart(startTime, userAgents, this.testCount, task.testStructure, task.opts); | |||
There was a problem hiding this comment.
I think we need to pass an object with the configuration field, not a configuration object: ``. It will help us prevent breaking changes if we need to add a new argument in the future.
|
✅ Tests for the commit d513a7c have passed. See details: |
AlexKamaev
approved these changes
May 27, 2020
AndreyBelym
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Having configuration options allows the reporter to provide additional info
Approach
Feeding options as a param to
reportTaskStartmethodReferences
#5088 (options have screenshot and video dir paths)
#3497 (screenshots/videos paths can be relativized)
Pre-Merge TODO