Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove navigation to idle page for non-persistent browser connections #5162

Closed
wants to merge 6 commits into from

Conversation

miherlosev
Copy link
Collaborator

@miherlosev miherlosev commented Jun 2, 2020

Changes:

  • set the same title [BrowserConnection.id] for each visited test page.
  • in BrowserConnectionGateway._onConnection method redirect to the first tested page instead of the idle page (only for non-persistent browser connections)
  • resize browser window on the first tested page during driver starting

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

miherlosev added a commit to miherlosev/testcafe that referenced this pull request Jun 15, 2020
@miherlosev miherlosev force-pushed the remove_idle_page branch 2 times, most recently from 865afe9 to 1409587 Compare June 15, 2020 11:57
@testcafe-build-bot
Copy link
Collaborator

miherlosev added a commit to miherlosev/testcafe that referenced this pull request Jun 15, 2020
@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

miherlosev added a commit to miherlosev/testcafe that referenced this pull request Jun 19, 2020
miherlosev added a commit that referenced this pull request Jun 19, 2020
* enhancements from #5162

* fix compilation
@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 42f1652 have failed. See details:

@miherlosev
Copy link
Collaborator Author

This PR contains a lot of Bootstrapper related changes. We decided to use another way and don't change Bootstrapper.
I will create a separate PR for this.

@miherlosev miherlosev closed this Jul 1, 2020
@miherlosev miherlosev deleted the remove_idle_page branch November 26, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants