Add TS defs for the window management API #5381
Conversation
|
❌ Tests for the commit 80822fc have failed. See details: |
| @@ -82,6 +82,20 @@ interface Browser { | |||
| prettyUserAgent: string; | |||
| } | |||
|
|
|||
| type WindowSelector = unknown; | |||
|
|
|||
| interface SwitchToWindowPredicateData { | |||
There was a problem hiding this comment.
I propose to rename this interface as SwithToWindowPredicate.
There was a problem hiding this comment.
SwitchToWindowPredicate is a function, this type represents its argument.
There was a problem hiding this comment.
We can use SwitchToWindowPredicateArgument instead.
There was a problem hiding this comment.
SwitchToWindowPredicateArgs?
There was a problem hiding this comment.
I tried to search the PredicateData, PredicateArgument and PredicateArgs names in https://github.com/DefinitelyTyped/DefinitelyTyped repository and I did not find such names.
The predicate data argument has a name that describes the entity passed there.
So, I propose the WindowData or WindowPartialData names.
There was a problem hiding this comment.
Args in different forms used in DefinitelyTyped:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/5344bfc80508c53a23dae37b860fb0c905ff7b24/types/wampy/index.d.ts#L15
There was a problem hiding this comment.
WindowData is a bit obscure. What do you think about WindowFilterData?
There was a problem hiding this comment.
Args is a common way to call event arguments in .NET. For me, it looks quite good. However, I don't mind if you call it WindowFilterData. I like that we have the word Filter in the name
|
✅ Tests for the commit 80822fc have passed. See details: |
|
✅ Tests for the commit 0a1547e have passed. See details: |
|
✅ Tests for the commit 0a1547e have passed. See details: |
Add definitions for the multiwindow API. Descriptions are taken from the pending PR to the docs: #5363.