Add 'object-curly-newline' eslint rule. #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests for the commit de6e1ce have passed. See details: |
AndreyBelym
reviewed
Sep 10, 2020
src/api/test-controller/index.js
Outdated
| MultipleWindowsModeIsDisabledError, | ||
| MultipleWindowsModeIsNotAvailableInRemoteBrowserError | ||
| } from '../../errors/test-run'; | ||
| import { MultipleWindowsModeIsDisabledError, MultipleWindowsModeIsNotAvailableInRemoteBrowserError } from '../../errors/test-run'; |
There was a problem hiding this comment.
Maybe we can enable consistent: true to allow separate long imports even when their number is below the critical value
|
❌ Tests for the commit 4f7f61b have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 4f7f61b have failed. See details: |
miherlosev
force-pushed
the
add_eslint_rule
branch
from
4f7f61b
to
68a73b1
Compare
|
❌ Tests for the commit 68a73b1 have failed. See details: |
|
✅ Tests for the commit 68a73b1 have passed. See details: |
|
FPR |
AndreyBelym
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5391 (comment)
The object-curly-newline affects the line breaks only inside of the statement (not after). However, I guess we can add this rule to standardize the new lines inside of
importstatements.The new lines are required if there are:
I added a special rule for tests because the statement
import { Selector, Role, t } from 'testcafe'with 3 items looks good.