Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed incorrect check visibility of an SVG element in a hidden element #6799

Merged
merged 4 commits into from Jan 19, 2022
Merged

fix: fixed incorrect check visibility of an SVG element in a hidden element #6799

merged 4 commits into from Jan 19, 2022

Conversation

Aleksey28
Copy link
Collaborator

@Aleksey28 Aleksey28 commented Dec 24, 2021 •
edited

[closes #3495]

Purpose

SVG elements without visibility properties should be checked correctly depending on parent elements.

Approach

  1. Add the tests to fix
  2. Add checking parent elements of the SVG

References

#3495

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI December 24, 2021 10:21 Inactive
@Aleksey28 Aleksey28 self-assigned this Dec 24, 2021
@Aleksey28 Aleksey28 temporarily deployed to CI December 24, 2021 12:28 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 27, 2021 07:05 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 27, 2021 10:16 Inactive
@AndreyBelym AndreyBelym merged commit 048f96e into DevExpress:master Jan 19, 2022
@Aleksey28 Aleksey28 deleted the gh3495 branch October 11, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miherlosev miherlosev miherlosev approved these changes

@AndreyBelym AndreyBelym AndreyBelym approved these changes

@LavrovArtem LavrovArtem Awaiting requested review from LavrovArtem

Assignees

@Aleksey28 Aleksey28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visibility check should incorporate visibility of parent element(s)
3 participants
@Aleksey28 @miherlosev @AndreyBelym