Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: added overlap config dashboard options with env options #7087

Merged
merged 9 commits into from
Jun 15, 2022

Conversation

Aleksey28
Copy link
Collaborator

[closes DevExpress/testcafe-private#4]

Purpose

Take dashboard env options if it exists instead of config options.

Approach

  1. Add test
  2. Added getting env dashboard options
  3. Added merge env options with previous options

References

https://github.com/DevExpress/testcafe-private/issues/4

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI June 14, 2022 08:40 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 14, 2022 09:00 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 14, 2022 10:30 Inactive
@Aleksey28 Aleksey28 self-assigned this Jun 14, 2022
@AndreyBelym AndreyBelym merged commit d4fbdf2 into DevExpress:master Jun 15, 2022
@github-actions
Copy link

Release v1.20.0-alpha.1 addresses this.

@Aleksey28 Aleksey28 deleted the dashboard branch October 11, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants