Fix: Incorrect cloud provider links are shown in report errors when running test in concurrency mode(closes #4346) #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rency mode, pass all sessions to reporter task start handler
AlexKamaev
approved these changes
Jul 7, 2022
|
Release v1.20.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When running tests in concurrency mode:
Approach
Previously we used the same reference of the "browserInfo" object in all the "browserConnection" objects. As a result, the browserMetaInfo was rewritten in all the "browserConnections".
After fix: Different "browserInfo" references are passed to different "browserConnections".
References
Show all links to all cloud test sessions in concurrency mode #4346
Pre-Merge TODO