fix: use calculated osInfo in userAgent #7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miherlosev
approved these changes
Apr 2, 2023
|
Release v2.5.1-rc.1 addresses this. |
1 similar comment
|
Release v2.5.1-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://github.com/DevExpress/testcafe-private/issues/147
Both the browserConnection.connectionInfo and browserConnection.userAgent are prettyUserAgent string. The only difference is in osInfo. In the case of userAgent it is calculated from the browser and usually it is incorrect.
Approach
Calculate osInfo in userAgent using the provider getOSInfo method.
References
https://github.com/DevExpress/testcafe-private/issues/147
Pre-Merge TODO