fix: quarantine and skipJsErrors CLI option value cannot be set to false(closes #7077) #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artem-Babich
force-pushed
the
fix-quarantine
branch
from
05dcb47
to
3e8c927
Compare
Artem-Babich
changed the title
miherlosev
requested changes
Apr 28, 2023
Artem-Babich
force-pushed
the
fix-quarantine
branch
from
083c6f2
to
0556130
Compare
miherlosev
approved these changes
May 2, 2023
|
Release v2.6.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
You cannot set the quarantine or skipJsErrors value to false via CLI. This should be allowed in order to have an ability to override the config file value
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
Provide a link to the existing issue(s), if any.
Pre-Merge TODO