Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native automation: run by default #7677

Conversation

miherlosev
Copy link
Collaborator

@miherlosev miherlosev commented May 4, 2023

Closes https://github.com/DevExpress/testcafe-private/issues/170
Closes https://github.com/DevExpress/testcafe-private/issues/169

Changes:

  • run nativeAutomation by default
  • rewrtie logging for the testRunController class
  • switch to the legacy run mode if there are browsers that don't support the native automation mode
  • refactorings

@miherlosev miherlosev temporarily deployed to CI May 4, 2023 04:19 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 4, 2023 04:29 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 4, 2023 07:55 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 4, 2023 08:23 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from 0070f00 to 2dd943c Compare May 4, 2023 08:26
@miherlosev miherlosev temporarily deployed to CI May 4, 2023 08:26 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 4, 2023 15:24 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 5, 2023 01:36 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 5, 2023 02:11 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 5, 2023 02:13 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from 21798e6 to 5545dcc Compare May 8, 2023 01:11
@miherlosev miherlosev temporarily deployed to CI May 8, 2023 01:11 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 8, 2023 01:55 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from ca28901 to 8742ea2 Compare May 8, 2023 01:57
@miherlosev miherlosev temporarily deployed to CI May 8, 2023 01:57 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 8, 2023 02:25 — with GitHub Actions Inactive
@miherlosev miherlosev requested a review from AlexKamaev May 8, 2023 08:46
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from d70ff78 to b2996c2 Compare May 12, 2023 01:04
@miherlosev miherlosev temporarily deployed to CI May 12, 2023 01:04 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from b2996c2 to 99c08d3 Compare May 15, 2023 02:50
@miherlosev miherlosev temporarily deployed to CI May 15, 2023 02:50 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from 99c08d3 to f7c47d7 Compare May 16, 2023 05:00
@miherlosev miherlosev temporarily deployed to CI May 16, 2023 05:00 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from f7c47d7 to af153e9 Compare May 16, 2023 05:48
@miherlosev miherlosev temporarily deployed to CI May 16, 2023 05:48 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from af153e9 to 8f52c50 Compare May 16, 2023 14:13
@miherlosev miherlosev temporarily deployed to CI May 16, 2023 14:13 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from 8f52c50 to 2582b57 Compare May 20, 2023 08:01
@miherlosev miherlosev temporarily deployed to CI May 20, 2023 08:01 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from 2582b57 to 0a11f24 Compare May 29, 2023 02:35
@miherlosev miherlosev temporarily deployed to CI May 29, 2023 02:35 — with GitHub Actions Inactive
@miherlosev miherlosev temporarily deployed to CI May 29, 2023 08:11 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from 59a9fa5 to 594847c Compare May 29, 2023 08:21
@miherlosev miherlosev temporarily deployed to CI May 29, 2023 08:21 — with GitHub Actions Inactive
@miherlosev miherlosev force-pushed the disable_native_automation_on_whole_test_run_level branch from 594847c to 40fe5c4 Compare May 30, 2023 01:46
@miherlosev miherlosev temporarily deployed to CI May 30, 2023 01:46 — with GitHub Actions Inactive
@miherlosev miherlosev merged commit 3f048ad into DevExpress:master May 30, 2023
18 of 19 checks passed
@miherlosev miherlosev deleted the disable_native_automation_on_whole_test_run_level branch May 30, 2023 03:04
Aleksey28 added a commit to Aleksey28/testcafe that referenced this pull request May 30, 2023
miherlosev pushed a commit that referenced this pull request May 31, 2023
This reverts commit 3f048ad.

<!--
Thank you for your contribution.

Before making a PR, please read our contributing guidelines at

https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution

We recommend creating a *draft* PR, so that you can mark it as 'ready
for review' when you are done.
-->

## Purpose
_Describe the problem you want to address or the feature you want to
implement._

## Approach
_Describe how your changes address the issue or implement the desired
functionality in as much detail as possible._

## References
_Provide a link to the existing issue(s), if any._

## Pre-Merge TODO
- [ ] Write tests for your proposed changes
- [ ] Make sure that existing tests do not fail
@github-actions
Copy link

Release v2.6.2-rc.1 addresses this.

Aleksey28 pushed a commit to Aleksey28/testcafe that referenced this pull request Jun 1, 2023
Closes DevExpress/testcafe-private#170
Closes DevExpress/testcafe-private#169

Changes:
* run nativeAutomation by default
* rewrtie logging for the `testRunController` class
* switch to the legacy run mode if there are browsers that don't support
the native automation mode
* refactorings
Aleksey28 added a commit that referenced this pull request Jun 4, 2023
Closes DevExpress/testcafe-private#170 Closes
DevExpress/testcafe-private#169

Changes:
* run nativeAutomation by default
* rewrtie logging for the `testRunController` class
* switch to the legacy run mode if there are browsers that don't support
the native automation mode
* refactorings

<!--
Thank you for your contribution.

Before making a PR, please read our contributing guidelines at

https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution

We recommend creating a *draft* PR, so that you can mark it as 'ready
for review' when you are done.
-->

## Purpose
_Describe the problem you want to address or the feature you want to
implement._

## Approach
_Describe how your changes address the issue or implement the desired
functionality in as much detail as possible._

## References
_Provide a link to the existing issue(s), if any._

## Pre-Merge TODO
- [ ] Write tests for your proposed changes
- [ ] Make sure that existing tests do not fail

Co-authored-by: Mikhail Losev <mlosev86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants