Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TestCafe Studio recorder stops working after a request hook is added #7721

Merged
merged 2 commits into from
May 25, 2023

Conversation

Dmitry-Ostashev
Copy link
Contributor

@Dmitry-Ostashev Dmitry-Ostashev commented May 23, 2023

Purpose

The t.addRequestHooks action crashes the TestCafe Studio recorder.

Approach

Specify that the addRequestHooks command should be executed only on the server side. This will make the recorder work.

References

https://github.com/DevExpress/testcafe-studio/issues/4350

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Dmitry-Ostashev Dmitry-Ostashev temporarily deployed to CI May 23, 2023 12:14 — with GitHub Actions Inactive
@Dmitry-Ostashev Dmitry-Ostashev changed the title fix: TestCafe Studio recorder stop working after adding request hook fix: TestCafe Studio recorder stops working after a request hook is added May 23, 2023
@Dmitry-Ostashev Dmitry-Ostashev temporarily deployed to CI May 24, 2023 17:04 — with GitHub Actions Inactive
@miherlosev miherlosev marked this pull request as ready for review May 25, 2023 03:46
@Dmitry-Ostashev Dmitry-Ostashev merged commit 5d7e57b into DevExpress:master May 25, 2023
19 checks passed
@github-actions
Copy link

Release v2.6.1-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants