-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: title node textContent returns incorrect value in native automation mode(closes #7833) #7840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also check fix with the skipped tests in test/functional/fixtures/regression/hammerhead/gh-2350/test.js
tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of restoring overriding, try using another approach:
- don't change title value in code (https://github.com/DevExpress/testcafe/blob/master/src/client/browser/idle-page/index.js#L17)
- close tab using CDP - https://github.com/DevExpress/testcafe/blob/master/src/browser/provider/built-in/dedicated/chrome/index.js#L121
Release v3.1.0-rc.1 addresses this. |
Purpose
Regression after disabling overrides(DevExpress/testcafe-hammerhead#2877).
Approach
Remove extra overridings from hammerhead(DevExpress/testcafe-hammerhead#2919)
References
#7833
DevExpress/testcafe-hammerhead#2919
Pre-Merge TODO