Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add testcafe version logging, add version export(closes #6591) #7850

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

Artem-Babich
Copy link
Contributor

@Artem-Babich Artem-Babich commented Jun 30, 2023

Purpose

Add version logging on TestCafe start.
export DEBUG="testcafe:version"
Add ability to check version in reporter: #6591

Approach

Add logging
Add version export

API

// Any script file:
import {version} from 'testcafe';

console.log(version);
//reporter method:

{
   init (testcafeVersion) { 
      this.write(`Using TestCafe v${testcafeVersion}`).newline()
   }
}

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Artem-Babich Artem-Babich temporarily deployed to CI June 30, 2023 13:54 — with GitHub Actions Inactive
src/utils/get-testcafe-version.ts Outdated Show resolved Hide resolved
src/utils/get-testcafe-version.ts Outdated Show resolved Hide resolved
src/utils/get-testcafe-version.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@miherlosev miherlosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think the reporter should be able to get the TestCafe version in its hooks. So, it's necessary to add the getTestCafeVersion method to the ReporterPluginHost class.

@Artem-Babich Artem-Babich temporarily deployed to CI July 4, 2023 10:42 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich temporarily deployed to CI July 4, 2023 10:47 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich merged commit bf58d0c into DevExpress:master Jul 12, 2023
21 checks passed
@Artem-Babich Artem-Babich deleted the add-testcafe-version branch July 12, 2023 08:19
@github-actions
Copy link

Release v3.1.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants