Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cookies are not cleared after role changing in proxy mode(closes #7874) #7888

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

Artem-Babich
Copy link
Contributor

@Artem-Babich Artem-Babich commented Jul 19, 2023

Do not merge until hammerhead dependency is updated

Purpose

#7874
The cookies mechanism works unexpectedly when the role URL and page URL are the same.

Approach

Update hammerhead navigateTo method.

References

DevExpress/testcafe-hammerhead#2937

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Artem-Babich Artem-Babich temporarily deployed to CI July 19, 2023 07:54 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich temporarily deployed to CI July 19, 2023 16:18 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich temporarily deployed to CI July 19, 2023 16:19 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich temporarily deployed to CI July 19, 2023 16:37 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich changed the title try update navigateTo fix: cookies are not cleared after role changing in proxy mode Jul 19, 2023
@Artem-Babich Artem-Babich changed the title fix: cookies are not cleared after role changing in proxy mode fix: cookies are not cleared after role changing in proxy mode(closes #7874) Jul 25, 2023
@Artem-Babich Artem-Babich temporarily deployed to CI August 3, 2023 09:28 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich merged commit a09559e into DevExpress:master Aug 7, 2023
20 checks passed
@Artem-Babich Artem-Babich deleted the fix-7874 branch August 7, 2023 08:11
@github-actions
Copy link

Release v3.2.0-rc.1 addresses this.

2 similar comments
@github-actions
Copy link

Release v3.2.0-rc.1 addresses this.

@github-actions
Copy link

Release v3.2.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants