Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor disableConcurrency from function to getter #8068

Merged
merged 11 commits into from
Nov 9, 2023

Conversation

PavelMor25
Copy link
Collaborator

@PavelMor25 PavelMor25 commented Nov 3, 2023

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Nov 3, 2023
@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Nov 3, 2023
/**
* Disables global concurrency setting for this fixture.
*/
disableConcurrency(): void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
disableConcurrency(): void;
disableConcurrency: this;

@PavelMor25 PavelMor25 changed the title fixed: added disableConcurrency() to ts-defs refactor: refactor disableConcurrency from function to getter Nov 6, 2023
Co-authored-by: Natalia Kazakova <17986517+natakazakova@users.noreply.github.com>
@aleks-pro aleks-pro merged commit e141279 into DevExpress:master Nov 9, 2023
19 of 20 checks passed
Copy link

github-actions bot commented Nov 9, 2023

Release v3.4.0-rc.3 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants