Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set default value on start page #28

Merged
merged 4 commits into from
May 15, 2024

Conversation

K1ethoang
Copy link
Member

No description provided.

Copy link

netlify bot commented Feb 28, 2024

👷 Deploy request for billsplit-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 11c1153

@Balastrong
Copy link
Member

Thanks for the PR!

This indeed works, but the idea is that the user should be able to decide a name and a number from the homepage, and from there pass the parameters to the new bill.

@K1ethoang
Copy link
Member Author

Okay, I will see it and remake

@K1ethoang
Copy link
Member Author

image
image

@Balastrong Help me to review code 💯

Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea using query params, LGTM! 🚀

@Balastrong Balastrong merged commit 1fa5afe into DevLeonardoCommunity:main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants