use tr to output the list of files #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On DevOpsHiveHQ#7 it's reported that when using MacOs' default `find`, it makes `kubechc` to crash. This PR aims at leveraging `tr` command instead to print the `:` separated list of files instead of relying on a flag only available in specific versions of `find`.
aabouzaid
reviewed
Oct 19, 2022
kubech
Outdated
| @@ -54,7 +54,7 @@ chmod 744 "${KUBECONFIG_SRC_DIR}" "${KUBECONFIG_DEST_DIR}" | |||
| # Handeling Kube config files. | |||
| _kubeconfig_files () { | |||
| if [ -d "${KUBECONFIG_SRC_DIR}" ]; then | |||
| KUBECONFIG_FILES="$(find "${KUBECONFIG_SRC_DIR}" -type f -printf '%p:')" | |||
| KUBECONFIG_FILES="$(find "${KUBECONFIG_SRC_DIR}" -type f -print0 | tr '/n' ':')" | |||
There was a problem hiding this comment.
It should be -print | tr '\n' ':'
Could you please check if it works on MacOS?
There was a problem hiding this comment.
His branch as-is works for me on macOS 12 using -print0. But i did notice "${KUBECONFIG_SRC_DIR} looks at ~/.kube/config.src.d/ for me which is empty.
There was a problem hiding this comment.
@defenestration that's why it doesn't really work (it will put everything as 1 line and there is no new line in the output).
Could you please test it using -print | tr '\n' ':'?
There was a problem hiding this comment.
Seems to work fine that way too, here is the diff against the branch in the PR for confirmation
diff --git a/kubech b/kubech
index 5576f70..68c60e9 100644
--- a/kubech
+++ b/kubech
@@ -54,7 +54,7 @@ chmod 744 "${KUBECONFIG_SRC_DIR}" "${KUBECONFIG_DEST_DIR}"
# Handeling Kube config files.
_kubeconfig_files () {
if [ -d "${KUBECONFIG_SRC_DIR}" ]; then
- KUBECONFIG_FILES="$(find "${KUBECONFIG_SRC_DIR}" -type f -print0 | tr '/n' ':')"
+ KUBECONFIG_FILES="$(find "${KUBECONFIG_SRC_DIR}" -type f -print | tr '\n' ':')"
fi
echo "${KUBECONFIG_FILES}${KUBECONFIG_ORIG}"
}There was a problem hiding this comment.
@defenestration thanks a lot for your feedback 👌
aabouzaid
requested changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #7 it's reported that when using MacOs' default
find, it makeskubechcto crash.This PR aims at leveraging
trcommand instead to print the:separated list of files instead of relying on a flag only available in specific versions offind.Eventho it's not a very scientific test, it works on my MacOS Monterrey mac. There's no reason for it not to work in any widespread linux distribution.