Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

fix for issues 14 and 22: footer now sticks to bottom of content #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardharrington
Copy link

No description provided.

@decause
Copy link
Member

decause commented Oct 5, 2016

@mattrothenberg @kahneraja

Wanna give this a look? +1 from me so long as it works as expected :)

@mattrothenberg
Copy link
Contributor

mattrothenberg commented Oct 5, 2016

@decause @kahneraja
I don't think @richardharrington's change will fix this issue. Instead of making the footer absolute, we should add more padding to the bottom of the containing element that the footer is fixed in. I'm actually unable to reproduce the issue on Mac Firefox myself.

@richardharrington
Copy link
Author

richardharrington commented Oct 5, 2016

@mattrothenberg That's what I would have thought if I had only seen #22 , but #14 seems to be saying we should get rid of the fixed nature of the footer entirely. Should we go with #14 , or should we ignore it and close it?

By the way, I can reproduce #22 on my Mac Firefox. It is pretty bad. #14 I also agree with, but it is a judgment call unlike #22.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants