Implement Google's page speed suggestions #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits minify local scripts (except main.js) using YUI Compressor, mark all scripts (except main.js again) as async so they don't block page load, and shrink the logo image to a size closer to how it gets displayed.
This nets us a ~13% reduction in page size and ~35% speedup in terms of waiting for DOMContentLoaded (time to fully loaded page is pretty much the same). In reality the background selfies are randomly selected, which changes both measures (in my testing I removed the randomness, but the measurements were still noisy).
I tried minifying main.css, but it somehow introduced a bug. It would also help to minify main.js, but then we'd have to redo that step every time we modify it, and I don't want our site to have a Makefile so I didn't do that.
cc #56