fix: plan output on error (#215)

* fix plan output on error Signed-off-by: Rishav Dhar <19497993+rdhar@users.noreply.github.com> * debug print `process.env.tf_plan_outline` Signed-off-by: Rishav Dhar <19497993+rdhar@users.noreply.github.com> * debug print Signed-off-by: Rishav Dhar <19497993+rdhar@users.noreply.github.com> * debug print Signed-off-by: Rishav Dhar <19497993+rdhar@users.noreply.github.com> * debug print Signed-off-by: Rishav Dhar <19497993+rdhar@users.noreply.github.com> * explicit boolean check of `tf_plan_outline` Signed-off-by: Rishav Dhar <19497993+rdhar@users.noreply.github.com> * clean up debug Signed-off-by: Rishav Dhar <19497993+rdhar@users.noreply.github.com> --------- Signed-off-by: Rishav Dhar <19497993+rdhar@users.noreply.github.com>
DevSecTop · May 26, 2024 · 5281cb5 · 5281cb5
1 parent 85327f7
commit 5281cb5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/action.yml b/action.yml
@@ -343,7 +343,7 @@ runs:
         tf_fmt: ${{ steps.render.outputs.tf_fmt }}
         tf_output: ${{ steps.render.outputs.tf_output }}
         tf_plan_id: ${{ steps.arguments.outputs.tf_plan_id }}
-        tf_plan_outline: ${{ inputs.plan_outline && steps.plan.outcome == 'success' }}
+        tf_plan_outline: ${{ steps.plan.outputs.exitcode == 0 && inputs.plan_outline }}
       with:
         retries: 3
         script: await require(`${process.env.GITHUB_ACTION_PATH}/scripts/comment_tf_output.js`)({ github, context, core, exec });

diff --git a/scripts/comment_tf_output.js b/scripts/comment_tf_output.js
@@ -41,7 +41,7 @@ ${process.env.tf_fmt}
 
   // Parse the TFplan file to extract an outline of changes.
   let comment_outline = "";
-  if (process.env.tf_plan_outline) {
+  if (process.env.tf_plan_outline === "true") {
     // Parse TFplan file.
     let tfplan = "";
     const data_handler = (data) => {