Correctly handle situation when choice cmd couldn't be found #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have all the choice binaries not working on my XP SP3 machine. *32 says "Cannot run program" and *32_alt and *64 both say "Not a Win32 program". But the script goes on doing useless and potentially harmful stuff. I suggest adding the proper handling as well as providing another binary. I found http://www.dynawell.com/download/ResKit/Microsoft/WinNT/choice.zip working for me (placed it as CHOICE32.EXE according to cmd line syntax it required) but there's also ftp://ftp.microsoft.com/Services/TechNet/samples/PS/Win98/Reskit/SCRPTING/CHOICE.EXE from Win98 that is likely more preferrable (the source is MS) and it worked on my PC too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have all the choice binaries not working on my XP SP3 machine. *32 says "Cannot run program" and *32_alt and *64 both say "Not a Win32 program". But the script goes on doing useless and potentially harmful stuff. I suggest adding the proper handling as well as providing another binary. I found this one working for me (placed it as CHOICE32.EXE according to cmd line syntax it required) but there's also binary from Win98(ftp://ftp.microsoft.com/Services/TechNet/samples/PS/Win98/Reskit/SCRPTING/CHOICE.EXE) that is likely more preferrable (the source is MS) and it worked on my PC too.
This change will probably fix #7