Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a page for search results #113

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Show a page for search results #113

merged 1 commit into from
Dec 12, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Dec 12, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

When doing a search, there's no way to display a page showing all the search results or "no result found".

What is the new behavior?

Added a page that shows search results.

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler added the enhancement Idea of improvement of existing feature. label Dec 12, 2021
@veler veler merged commit 23c5038 into main Dec 12, 2021
@veler veler deleted the search-results branch December 12, 2021 05:07
veler added a commit that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant