Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Lorem Ipsum Generator tool #130

Merged
merged 8 commits into from
Jan 4, 2022
Merged

Added Lorem Ipsum Generator tool #130

merged 8 commits into from
Jan 4, 2022

Conversation

ivankahl
Copy link
Contributor

@ivankahl ivankahl commented Jan 1, 2022 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

There is currently no Lorem Ipsum tool.

Issue Number: #73

What is the new behavior?

  • Created a new tool under the Generators section for Lorem Ipsum
  • Tool can generate Lorem Ipsum text with the following parameters
    • Type: Words, Sentences, Paragraphs
    • Length: How many words/sentences/paragraphs to generate

Other information

NLipsum

I have used the NLipsum library to generate the Lorem Ipsum text. It is quite feature-rich so we can extend this tool later if need be and still use NLipsum.

NLipsum is also licensed under the MIT license.

Screenshots

Icon in All Tools screen

Icon in All Tools screen

Tool in navigation menu

Tool in navigation menu

Demo video

Demo.mp4

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@ivankahl ivankahl marked this pull request as ready for review January 1, 2022 15:26
@ivankahl ivankahl mentioned this pull request Jan 1, 2022
Closed
@veler veler requested review from btiteux and veler and removed request for btiteux January 1, 2022 18:37
@veler veler added the enhancement Idea of improvement of existing feature. label Jan 1, 2022
@veler veler linked an issue Jan 1, 2022 that may be closed by this pull request
Add a Lorem Ipsum Generator tool #73
Closed
veler
veler requested changes Jan 1, 2022
View reviewed changes
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this! Overall, it's excellent :D I will let @btiteux taking a look at it too.

src/dev/impl/DevToys/DevToys.csproj Outdated Show resolved Hide resolved
veler
veler requested changes Jan 4, 2022
View reviewed changes
src/dev/impl/DevToys/DevToys.csproj Outdated Show resolved Hide resolved
veler
veler approved these changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much! :D Merging it in main branch, but we will release it in an update after 1.0.0.0 :)

@veler veler merged commit 838f915 into DevToys-app:main Jan 4, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
@ivankahl
Added Lorem Ipsum Generator tool (#130)
2a42504 
* Added LoremIpsum strings and updated Language Manager

* Added tool icon

* Lorem Ipsum View and ViewModels

* Fixed resource references in csproj

* Added third party notices for NLipsum

* Added NuGet version for NLipsum to Directory.Build.props

* Updated README to reflect new tool and protocol

* Removed the version tag for NLipsum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veler veler veler approved these changes

@btiteux btiteux Awaiting requested review from btiteux

Assignees
No one assigned
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Lorem Ipsum Generator tool
2 participants
@ivankahl @veler