Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all encoder/decoder tools dropdown with a toggle switch #169

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Replaced all encoder/decoder tools dropdown with a toggle switch #169

merged 4 commits into from
Jan 21, 2022

Conversation

akarboush
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe): enhancement: replaced all encoder/decoder tools dropdown with a toggle switch

What is the current behavior?

Issue Number: #154

What is the new behavior?

gif

Other information

The conversion mode is now saved in setting as a boolean instead of string, since we only have the two options encode and decode

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for proposing this change! It looks all good to me :)

@veler veler added the enhancement Idea of improvement of existing feature. label Jan 21, 2022
@veler veler linked an issue Jan 21, 2022 that may be closed by this pull request
@veler veler merged commit 373c08f into DevToys-app:main Jan 21, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
* Replaced html encoder/decoder tool dropdown with a toggle switch

* Replaced base64 encoder/decoder tool dropdown with a toggle switch

* Replaced url encoder/decoder tool dropdown with a toggle switch

* Fix base64 encoder/decoder test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Toggle for Encode/Decode options
2 participants