Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GZip compression handling to the Base64 Encode/Decode Tool #218

Closed
wants to merge 5 commits into from
Closed

Add GZip compression handling to the Base64 Encode/Decode Tool #218

wants to merge 5 commits into from

Conversation

AHollowedHunter
Copy link

@AHollowedHunter AHollowedHunter commented Jan 23, 2022

Pull request type

Please check the type of change your PR introduces:

  • Feature

What is the current behavior?

Currently you cannot decode a GZip compressed Base64 string, or encode a string with compression applied.

Issue Number: closes #217

What is the new behavior?

  • Added a toggle option to enable/disable GZip compression handling

Other information

Screenshot of base64 encoder with GZip compression added

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@btiteux
Copy link
Collaborator

btiteux commented Jan 24, 2022

Hello,
Thank you for the pull request, since you are two with the same pull request and after discussion with @veler we are going to continue with the other pull request (#214) allowing us to extend in the future this feature.
Thank you for your work.

@btiteux btiteux closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GZip compression/decompression to Base64 Encoder/Decoder
2 participants